Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tqdm auto #35726

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Use tqdm auto #35726

wants to merge 5 commits into from

Conversation

SmartManoj
Copy link

@SmartManoj SmartManoj commented Jan 16, 2025

What does this PR do?

Remove traces like this in the notebook.

image

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1
Copy link
Member

I don't think leaving it is terrible, WDYT @ArthurZucker?

@SmartManoj
Copy link
Author

Attached the image.

@Rocketknight1
Copy link
Member

Hi @SmartManoj, a better fix might by dynamic_ncols=True rather than leave=False. That should avoid the bar being printed on every line when your terminal is narrow. Try it and let me know if that works!

@SmartManoj SmartManoj changed the title Remove traces of the progress bar Use tqdm auto Jan 17, 2025
@SmartManoj
Copy link
Author

No diff in all the 3 variations. test nb.

Seems, due to the warnings in the initial notebook caused this. Related issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants