Add do_convert_rgb to vit #34523
Merged
Add do_convert_rgb to vit #34523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubvel
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Hi @jp1924, thanks for adding this feature! To make it complete we also have to update VitImageProcessorFast to be compatible with this image processor. Please have a look if there is a required transform in torchvision or use Lambda transform. Thanks!
Co-authored-by: Pavel Iakubovskii <[email protected]>
Co-authored-by: Pavel Iakubovskii <[email protected]>
Co-authored-by: Pavel Iakubovskii <[email protected]>
|
Thanks for the advice @qubvel! That worked out well. I wrote that type_hint with reference to siglip, should I modify siglip as well? |
|
@qubvel |
qubvel
approved these changes
Nov 15, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Nov 19, 2024
4 tasks
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* Add: do_convert_rgb * Add: doc string * Update src/transformers/models/vit/image_processing_vit.py Co-authored-by: Pavel Iakubovskii <[email protected]> * Update src/transformers/models/vit/image_processing_vit.py Co-authored-by: Pavel Iakubovskii <[email protected]> * Update src/transformers/models/vit/image_processing_vit.py Co-authored-by: Pavel Iakubovskii <[email protected]> * Add: do_convert_rgb to fast * Add: convert_to_rgb --------- Co-authored-by: Pavel Iakubovskii <[email protected]>
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
* Add: do_convert_rgb * Add: doc string * Update src/transformers/models/vit/image_processing_vit.py Co-authored-by: Pavel Iakubovskii <[email protected]> * Update src/transformers/models/vit/image_processing_vit.py Co-authored-by: Pavel Iakubovskii <[email protected]> * Update src/transformers/models/vit/image_processing_vit.py Co-authored-by: Pavel Iakubovskii <[email protected]> * Add: do_convert_rgb to fast * Add: convert_to_rgb --------- Co-authored-by: Pavel Iakubovskii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
While resolving issue #34301, discovered that ViT lacks do_rgb_convert.
Therefore, added do_rgb_convert to ViTImageProcessor.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@amyeroberts, @qubvel