Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix speecht5 failure issue in test_peft_gradient_checkpointing_enable… #34454

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

sywangyi
Copy link
Contributor

…_disable

What does this PR do?

Fixes # (issue)
#33527

@sywangyi
Copy link
Contributor Author

sywangyi commented Nov 4, 2024

@amyeroberts

@Rocketknight1
Copy link
Member

gentle ping @ylacombe @eustlb

@yao-matrix
Copy link

@Rocketknight1 gentle ping.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks clean, and I'm sorry the review took so long! I should have just approved it the first time around, given that it clearly fixes the problem.

@Rocketknight1 Rocketknight1 merged commit 125de41 into huggingface:main Dec 3, 2024
27 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
huggingface#34454)

* fix speecht5 failure issue in test_peft_gradient_checkpointing_enable_disable

Signed-off-by: Wang, Yi <[email protected]>

* [run-slow] speecht5

---------

Signed-off-by: Wang, Yi <[email protected]>
Co-authored-by: Matt <[email protected]>
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
huggingface#34454)

* fix speecht5 failure issue in test_peft_gradient_checkpointing_enable_disable

Signed-off-by: Wang, Yi <[email protected]>

* [run-slow] speecht5

---------

Signed-off-by: Wang, Yi <[email protected]>
Co-authored-by: Matt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants