Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated timesformer.md to Korean #33972

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

mreraser
Copy link
Contributor

@mreraser mreraser commented Oct 5, 2024

What does this PR do?

Translated the timesformer.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

May you please review this PR?
@yijun-lee, @mreraser, @jungnerd, @cjfghk5697

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

Hello @stevhliu ! May you please review this PR? Thank you!
Have a nice day :)

@mreraser
Copy link
Contributor Author

mreraser commented Oct 8, 2024

Hello! @yijun-lee, @jungnerd, @cjfghk5697
May I kindly ask for your review? Thank you for your consistent reviews 🤗

@mreraser mreraser marked this pull request as ready for review October 15, 2024 03:52
@cjfghk5697
Copy link
Contributor

LGTM!

@Rocketknight1
Copy link
Member

cc @stehvliu!

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Comment on lines 659 to 661
sections:
- local: model_doc/timesformer.md
title: TimeSFormer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your alignment may be off here. Should look like:

- isExpanded: false
  sections:
  - local: model_doc/timesformer
    title: TimeSFormer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I might have missed that. 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops looks like the toctree still isn't properly aligned! The line here should be aligned with the one here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevhliu I have completed modifying the toctree, thank you!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit 1cf1707 into huggingface:main Nov 7, 2024
9 checks passed
2015aroras pushed a commit to 2015aroras/transformers that referenced this pull request Nov 14, 2024
* docs: ko: model_doc/timesformer.md

* feat: nmt draft

* fix: manual edits

* fix_toctree

* fix toctree on Video Models
2015aroras pushed a commit to 2015aroras/transformers that referenced this pull request Nov 15, 2024
* docs: ko: model_doc/timesformer.md

* feat: nmt draft

* fix: manual edits

* fix_toctree

* fix toctree on Video Models
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
* docs: ko: model_doc/timesformer.md

* feat: nmt draft

* fix: manual edits

* fix_toctree

* fix toctree on Video Models
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
* docs: ko: model_doc/timesformer.md

* feat: nmt draft

* fix: manual edits

* fix_toctree

* fix toctree on Video Models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants