-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update llm_engine.py #33332
Update llm_engine.py #33332
Conversation
- Added support for optional token and max_tokens parameters in the constructor. - Provided usage examples and detailed documentation for each method.
cc @aymeric-roucher for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes, thanks a lot @louisbrulenaudet!
@louisbrulenaudet you'll just have to do a few style fixes (trailing whitespaces) before being able to merge. |
Trailing whitespaces correction
Applying the Format Changes Automatically.
Hi @aymeric-roucher, normally I've made the necessary corrections and removed the whitespaces, but I'm still getting a validation error that I can't explain. Could you tell me what you think is wrong? |
@louisbrulenaudet the error in both
I believe it might be because 3 of the 4 arguments are defined as |
Hello @aymeric-roucher, I have the impression that all the tests have been passed, thank you again for your information and your help, I hope that everything will go well from now on and wish you a good day. |
It's merged! Thanks a lot for this PR @louisbrulenaudet 🤗 |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
* Update llm_engine.py - Added support for optional token and max_tokens parameters in the constructor. - Provided usage examples and detailed documentation for each method.
What does this PR do?
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.