Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n-ar] Translated file : docs/source/ar/quicktour.md into Arabic #33069

Closed
wants to merge 31 commits into from
Closed

[i18n-ar] Translated file : docs/source/ar/quicktour.md into Arabic #33069

wants to merge 31 commits into from

Conversation

AhmedAlmaghz
Copy link
Contributor

What does this PR do?

Translated the docs/source/ar/quicktour.md file of the documentation to Arabic العربية. I use transformers for my side-project and wanted to contribute. As a beginner, this seemed appropriate.

Some questions:

  • I can't access the pr documentation endpoint for Arabic العربية. Is there a missing step?
  • I left all the other files alone after copying the English docs. Is this acceptable for future updates or should I add contents to the _toctree.yml only when translation is complete? Should I delete all other files for a cleaner review?
  • In Arabic, people use both Transformer and المحولات to describe the model. However, as this is more of a product of HuggingFace I opted not to translate it. May you please let me know which you would prefer?

Thank you in advance for your review.

Part of #32435

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum ?Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu , @MKhalusova , @abodacs, may you please review this PR?

This was referenced Aug 26, 2024
Open
Closed
abodacs
abodacs suggested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@abodacs abodacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

سﻻم عليكم

شكرا لمجهودك @AhmedAlmaghz

تم اضافة بعض تعليقات

docs/source/ar/quicktour.md Outdated Show resolved Hide resolved
docs/source/ar/quicktour.md Outdated Show resolved Hide resolved
docs/source/ar/quicktour.md Show resolved Hide resolved
docs/source/ar/quicktour.md Outdated Show resolved Hide resolved
docs/source/ar/quicktour.md Outdated Show resolved Hide resolved
docs/source/ar/quicktour.md Outdated Show resolved Hide resolved
docs/source/ar/quicktour.md Outdated Show resolved Hide resolved
docs/source/ar/quicktour.md Outdated Show resolved Hide resolved
docs/source/ar/quicktour.md Outdated Show resolved Hide resolved
docs/source/ar/quicktour.md Outdated Show resolved Hide resolved
@abodacs
Copy link
Contributor

abodacs commented Aug 29, 2024

Hi, @stevhliu

Any tag Tip rendered from left-to-right instead of right-to-left

Any Tip :) to make it work in Arabic right-to-left

cc: @AhmedAlmaghz

AhmedAlmaghz and others added 25 commits August 30, 2024 01:48
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
4e9809a 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
de5b1c5 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
3cd324f 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
2d7d766 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
f9c0972 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
68f5648 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
ee4ee15 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
d5db2c1 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
be88ad6 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
415a589 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
d5ac574 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
0c4b7b4 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
158d35a 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
a1b5b38 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
e15a192 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
75eb9cf 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
3b8b99a 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
16b17c0 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
f60a60e 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
6baf7ff 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
7ff7ab7 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
30b1a13 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
73c4b34 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
5c694f0 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/quicktour.md
9422205 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz
Copy link
Contributor Author

اشكرك أخي عبدالله @abodacs
جزيل الشكر على المراجعة والملاحظات القيمة.
تحياتي وتقديري الكبيرين لشخصكم الكريم

@AhmedAlmaghz AhmedAlmaghz marked this pull request as ready for review August 29, 2024 23:05
@AhmedAlmaghz
Copy link
Contributor Author

AhmedAlmaghz commented Aug 29, 2024 •
edited
Loading

@abodacs
مشكلة RTL و LTR سوف تٌحل عند تشغيل الوثائق في الموقع
<html lang="ar" dir="RTL" >

@AhmedAlmaghz
Copy link
Contributor Author

@abodacs

التالي :
Installation #33041

stevhliu
stevhliu reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

Any Tip :) to make it work in Arabic right-to-left

Sorry, I'm not sure how to make the Tip blocks go from right-to-left!

docs/source/ar/quicktour.md Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@AhmedAlmaghz AhmedAlmaghz deleted the Add_docs_source_ar_quicktour.md branch September 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevhliu stevhliu stevhliu left review comments

@abodacs abodacs abodacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AhmedAlmaghz @abodacs @HuggingFaceDocBuilderDev @stevhliu