-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bnb support for Ascend NPU #31512
base: main
Are you sure you want to change the base?
Conversation
Thanks @statelesshz ! |
Hey all! I'm only aware of a backend stub that was added on the multi-backend-refactor branch by @statelesshz, no implementation logic. There wasn't much context given on the PR at the time, but since the implementation was yet to come, for me that was ok as is; as an incremental step. @statelesshz Could you please elaborate a bit more what you mean by the following statement? Where does your implementation live right now?
Generally, there've been quite a lot of changes in 0.43.0 and even 0.43.1 (the setup logic), so it would be really advisable to already take those changes into account. Regarding the timeline: we'll go into public alpha/beta testing of the Intel/AMD backends, finalize the refactoring (integrating with the Torch dispatcher through the torch.library API) in the next weeks and do a full release soon after. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
cf1894c
to
06c3eb8
Compare
@younesbelkada @Titus-von-Koeller Good day! I have submitted a PR to add nf4 quant/dequant support to Ascend NPU. The corresponding end-to-end test results are as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on @matthewdouglas comments ! LGTM otherwise
@SunMarc I have deleted the changes of "Bnb4BitHfQuantizer". But CI has an error when executing check_repository_consistency. The specific error information is as follows:
I tried to fix this problem locally based on the error message. After executing Any guidance would be appreciated. |
Hey @statelesshz , this happens because this method have the following comment above: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Hey @SunMarc, thanks for your suggestion, it worked. CI reported that there was one test case failing, I think it's not caused by this PR. |
Indeed this is not related. Can you try to rebase the PR ? I've also pinged Arthur for a final check before merging |
@SunMarc done! 🤗 |
Hey @ArthurZucker, could you help take a look at this PR, thanks :-) |
Hey @ArthurZucker , this PR addresses a key issue I'm also facing, and I'm hoping it can be merged soon. Thanks! |
What does this PR do?
This PR can make bnb nf4 QLoRA out of the box on Ascend NPUs. 🤗
Related PR: bitsandbytes-foundation/bitsandbytes#1422
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.