[auto. ping] Avoid sending empty info + add more team members (#34383)

* update * update --------- Co-authored-by: ydshieh <[email protected]>
huggingface · Oct 24, 2024 · a308d28 · a308d28
1 parent 4c6e0c9
commit a308d28
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/.github/workflows/check_failed_model_tests.yml b/.github/workflows/check_failed_model_tests.yml
@@ -106,7 +106,7 @@ jobs:
           } >> "$GITHUB_ENV"
 
       - name: Send processed report
-        if: ${{ env.REPORT_TEXT != '' }}
+        if: ${{ !endsWith(env.REPORT_TEXT, '{}') }}
         uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001
         with:
           # Slack channel id, channel name, or user id to post message.

diff --git a/utils/check_bad_commit.py b/utils/check_bad_commit.py
@@ -182,7 +182,15 @@ def get_commit_info(commit):
                 info = {"test": test, "commit": commit}
                 info.update(get_commit_info(commit))
                 failed_tests_with_bad_commits.append(info)
-            reports[model]["single-gpu"] = failed_tests_with_bad_commits
+
+            # If no single-gpu test failures, remove the key
+            if len(failed_tests_with_bad_commits) > 0:
+                reports[model]["single-gpu"] = failed_tests_with_bad_commits
+            else:
+                reports[model].pop("single-gpu", None)
+
+        # remove the models without any test failure
+        reports = {k: v for k, v in reports.items() if len(v) > 0}
 
         with open(args.output_file, "w", encoding="UTF-8") as fp:
             json.dump(reports, fp, ensure_ascii=False, indent=4)
diff --git a/utils/process_bad_commit_report.py b/utils/process_bad_commit_report.py
@@ -28,7 +28,18 @@
         data = json.load(fp)
 
     # TODO: extend
-    team_members = ["ydshieh", "zucchini-nlp", "ArthurZucker", "gante", "LysandreJik", "molbap", "qubvel"]
+    team_members = [
+        "ydshieh",
+        "zucchini-nlp",
+        "ArthurZucker",
+        "gante",
+        "LysandreJik",
+        "molbap",
+        "qubvel",
+        "Rocketknight1",
+        "muellerzr",
+        "SunMarc",
+    ]
 
     # Counting the number of failures grouped by authors
     new_data = {}