Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to marlin-kernels 0.3.7 #2882

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Update to marlin-kernels 0.3.7 #2882

merged 1 commit into from
Jan 10, 2025

Conversation

danieldk
Copy link
Member

@danieldk danieldk commented Jan 6, 2025

What does this PR do?

This fixes a race condition. See:

vllm-project/vllm#11493

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

drbh
drbh previously approved these changes Jan 9, 2025
Copy link
Collaborator

@drbh drbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ LGTM!

This fixes a race condition. See:

vllm-project/vllm#11493
@danieldk danieldk force-pushed the marlin-kernels-0.3.7 branch from becbd59 to 4f9c6a5 Compare January 9, 2025 15:29
@danieldk danieldk merged commit 4f7e00f into main Jan 10, 2025
13 of 15 checks passed
@danieldk danieldk deleted the marlin-kernels-0.3.7 branch January 10, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants