Add fp8 kv cache for ROCm #2856
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
reviewed
Jan 10, 2025
Comment on lines
+68
to
+71
| self.kv_cache_dtype = "auto" | ||
| if SYSTEM == "rocm" and dtype == torch.float8_e4m3fn: | ||
| self.kv_cache_dtype = "fp8" | ||
| dtype = torch.uint8 |
There was a problem hiding this comment.
I think it would be nicer to allocate the cache in the requested type (torch.float8_e4m3fn) and then cast to uint8 where/when needed. Then we don't need another bookkeeping field (kv_cache_dtype) and the cache carries the type information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title!
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.