Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Phi 3.5 MoE tests #2684

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix Phi 3.5 MoE tests #2684

merged 1 commit into from
Oct 24, 2024

Conversation

danieldk
Copy link
Member

@danieldk danieldk commented Oct 24, 2024

What does this PR do?

PR #2682 also fixed in issue in Phi MoE, but it changes the test outputs a bit. Fix this.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

PR #2682 also fixed in issue in Phi MoE, but it changes the test
outputs a bit. Fix this.
@danieldk danieldk merged commit 14a0df3 into main Oct 24, 2024
8 of 10 checks passed
@danieldk danieldk deleted the maintenance/phi35-test-fix branch October 24, 2024 13:21
@OlivierDehaene
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants