Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile fixes for Xcode 14.3.1 #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rrva
Copy link

@rrva rrva commented Aug 3, 2023

Did not compile on Xcode 14.3.1

Cannot convert value of type '()' to expected condition type 'Bool'

Did not compile on Xcode 14.3.1
@rrva
Copy link
Author

rrva commented Aug 3, 2023

Fixes #70

@@ -22,8 +22,8 @@ let deviceHas6GBOrMore = ProcessInfo.processInfo.physicalMemory > 5924000000 /

let deviceSupportsQuantization = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you possibly just also include the implicit declaration of type as well?

let deviceSupportsQuantization: Bool = {

I've had the compiler complain when this was missing a few times as well.

Have you tested that the current code builds in 14.3.1 with the current StableDiffusion package with these changes?

@ghost
Copy link

ghost commented Aug 7, 2023

could you possibly just also include the implicit declaration of type as well?

let deviceSupportsQuantization: Bool = {

I've had the compiler complain when this was missing a few times as well.

Have you tested that the current code builds in 14.3.1 with the current StableDiffusion package with these changes?

@dkman94
Copy link

dkman94 commented Jan 24, 2024

Had the same issue, and this fixes the problem in 14.3.1 for me as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants