Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiStepAgent logs in JSON serializable format. #148

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

benediktstroebl
Copy link

Added method to MultiStepAgent class that returns logs in a JSON serializable format. It also parses tool call arguments and action outputs.

This method is handy for storing logs in a pretty format that is easy to read and use further.

@aymeric-roucher
Copy link
Collaborator

@benediktstroebl indeed, this json serializable format can be helpful when logging stuff! Could you keep only the json serialization format in this PR? (since parsing json tool calls is already done in other PRs like #163)

@benediktstroebl
Copy link
Author

@aymeric-roucher Sounds good! I removed the other edits from the PR. This one now only contains the edits related to the new json serialization method to_json().

@clefourrier
Copy link
Member

clefourrier commented Jan 24, 2025

Hi @benediktstroebl ! I'm currently redoing the logging, and reused a lot of your code in #316 - would you be OK with being a co-author of my PR?
(I changed the logic where it happens)

@benediktstroebl
Copy link
Author

Hi @benediktstroebl ! I'm currently redoing the logging, and reused a lot of your code in #316 - would you be OK with being a co-author of my PR? (I changed the logic where it happens)

Hi @clefourrier, that sounds good! Let's co-author it. Can you add me to your PR so we can close this one?

@clefourrier
Copy link
Member

Yep! I think I need your email for this

@clefourrier
Copy link
Member

Or you can add a code suggestion somewhere using ```suggestion
(like in a docstring) and I can commit it which should make you a coauthor

@benediktstroebl
Copy link
Author

@clefourrier Done. I added a docstring to the function in utils.py you used from my code IIC. Thanks!

@clefourrier
Copy link
Member

Hm, I'm not finding it in my PR?

@benediktstroebl
Copy link
Author

Can you see it now?

@clefourrier
Copy link
Member

Yep, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants