-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiStepAgent logs in JSON serializable format. #148
base: main
Are you sure you want to change the base?
Conversation
…on serializable format. It also parses arguments to tool calls.
…do not get parsed as dict but as str and are treated as a single argument leading to error.
@benediktstroebl indeed, this json serializable format can be helpful when logging stuff! Could you keep only the json serialization format in this PR? (since parsing json tool calls is already done in other PRs like #163) |
@aymeric-roucher Sounds good! I removed the other edits from the PR. This one now only contains the edits related to the new json serialization method |
Hi @benediktstroebl ! I'm currently redoing the logging, and reused a lot of your code in #316 - would you be OK with being a co-author of my PR? |
Hi @clefourrier, that sounds good! Let's co-author it. Can you add me to your PR so we can close this one? |
Yep! I think I need your email for this |
Or you can add a code suggestion somewhere using ```suggestion |
@clefourrier Done. I added a docstring to the function in utils.py you used from my code IIC. Thanks! |
Hm, I'm not finding it in my PR? |
Can you see it now? |
Yep, merged! |
Added method to MultiStepAgent class that returns logs in a JSON serializable format. It also parses tool call arguments and action outputs.
This method is handy for storing logs in a pretty format that is easy to read and use further.