Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Module 2 Bug] Fixing wrong args passed to DPOTrainer #124

Merged
merged 2 commits into from
Jan 8, 2025
Merged

[Module 2 Bug] Fixing wrong args passed to DPOTrainer #124

merged 2 commits into from
Jan 8, 2025

Conversation

Knight7561
Copy link
Contributor

Notes:

  • Wrong args were passed to DPOTrainer which had to be passed for DPOConfig.

@Knight7561
Copy link
Contributor Author

Also, For me report_to='none' worked instead of report_to=None,. Should I make that change as well ? @burtenshaw

@Knight7561 Knight7561 changed the title Fixing wrong args passed to DPOTrainer [Module 2 Bug] Fixing wrong args passed to DPOTrainer Dec 18, 2024
@Knight7561 Knight7561 marked this pull request as ready for review December 18, 2024 21:40
@Knight7561 Knight7561 mentioned this pull request Dec 22, 2024
Open
15 tasks
@Knight7561
Copy link
Contributor Author

Partially it is fixed by #120 by revoking those properties, this PR would move them to config

burtenshaw
burtenshaw approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@burtenshaw burtenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks for the consideration on this.

Have you already joined the discord?
Hugging Face Discord: https://discord.gg/hugging-face-879548962464493619
Smol course channel: https://discord.com/channels/879548962464493619/1313889336907010110

@burtenshaw burtenshaw merged commit dce7afb into huggingface:main Jan 8, 2025
@Knight7561
Copy link
Contributor Author

@burtenshaw Yes I am a participant in discord and channel.
Thanks for the invite ..! Cheers

@Knight7561 Knight7561 deleted the fix-module-2 branch January 8, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burtenshaw burtenshaw burtenshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Knight7561 @burtenshaw