Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Module 1 Example #122

Merged

Conversation

1sarthakbhardwaj
Copy link
Contributor

@1sarthakbhardwaj 1sarthakbhardwaj commented Dec 18, 2024

December 2024 Student Submission

Module Completed

  • Module 1: Instruction Tuning
  • Module 2: Preference Alignment
  • Module 3: Parameter-efficient Fine-tuning
  • Module 4: Evaluation
  • Module 5: Vision-language Models
  • Module 6: Synthetic Datasets
  • Module 7: Inference
  • Module 8: Deployment

Changes Made

Describe what you've done in this PR:

  1. What concepts did you learn?
  2. What changes or additions did you make?
  3. Any challenges you faced?

Notebooks Added/Modified

List any notebooks you've added or modified:

  • Added new example in module_name/student_examples/my_example.ipynb
  • Modified existing notebook with additional examples
  • Added documentation or comments

Checklist

  • I have read the module materials
  • My code runs without errors
  • I have pushed models and datasets to the huggingface hub
  • My PR is based on the december-2024 branch

Questions or Discussion Points

Add any questions you have or points you'd like to discuss:
1.
2.

Additional Notes

Any other information that might be helpful for reviewers:

@Bipul70701
Copy link

Hi @1sarthakbhardwaj
I have reviewed your notebook. Well done!
The model is also uploaded to Huggingface.
@burtenshaw Could you please merge?

@1sarthakbhardwaj
Copy link
Contributor Author

Hi @burtenshaw, can you check if it's good to merge?

Copy link
Collaborator

@burtenshaw burtenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

@burtenshaw burtenshaw merged commit d81ea28 into huggingface:december-2024 Jan 8, 2025
@1sarthakbhardwaj
Copy link
Contributor Author

Cheers!

@1sarthakbhardwaj 1sarthakbhardwaj deleted the december-2024 branch January 8, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants