Restore compatibility with Rust 1.74 #563
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR huggingface#544 added support for `no_std` feature. The PR changed `std::error::Error` to `core::error::Error`. The `core::error` trait was stabilized in Rust 1.81, so the change bumped MSRV to 1.81. Before the Python package built with Rust 1.66 and the `safetensors` create with all features built with 1.74. This commit restores compatibility with Rust 1.74 for `std` builds: - `mixed_integer_ops` feature requires 1.66 - `half v2.4.1` requires 1.70 - `clap_lex v0.7.4` requires 1.74 I'm also adding `rust-version` to `Cargo.toml`, so cargo creates a backwards compatible `Cargo.lock`. By default, Cargo >= 1.83 creates a `v4` lock file, which is not compatible with Cargo < 1.78. Signed-off-by: Christian Heimes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR #544 added support for
no_stdfeature. The PR changedstd::error::Errortocore::error::Error. Thecore::errortrait was stabilized in Rust 1.81, so the change bumped MSRV to 1.81. Before the Python package built with Rust 1.66 and thesafetensorscreate with all features built with 1.74.This commit restores compatibility with Rust 1.74 for
stdbuilds:mixed_integer_opsfeature requires 1.66half v2.4.1requires 1.70clap_lex v0.7.4requires 1.74I'm also adding
rust-versiontoCargo.toml, so cargo creates a backwards compatibleCargo.lock. By default, Cargo >= 1.83 creates av4lock file, which is not compatible with Cargo < 1.78.