Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong signature of safe_open.__init__ in stub file #557

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

SunghwanShim
Copy link
Contributor

@SunghwanShim SunghwanShim commented Jan 7, 2025

What does this PR do?

First argument of safe_open.__init__ (self) is omitted. So add it.

@Narsil
Copy link
Collaborator

Narsil commented Jan 8, 2025

Thanks.

I don't write those files manually, they are generated via a script. Seems like PyO3 changed something in the generated Python that I overlooked. I fixed the script too now.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Narsil Narsil merged commit adeda63 into huggingface:main Jan 8, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants