Memory map as private pure copy. (#553)

huggingface · Jan 2, 2025 · e61e872 · e61e872
1 parent b4a9ec7
commit e61e872
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/bindings/python/Cargo.toml b/bindings/python/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "safetensors-python"
-version = "0.5.0-dev.0"
+version = "0.5.1-dev.0"
 edition = "2021"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

diff --git a/bindings/python/src/lib.rs b/bindings/python/src/lib.rs
@@ -406,7 +406,7 @@ impl Open {
 
         // SAFETY: Mmap is used to prevent allocating in Rust
         // before making a copy within Python.
-        let buffer = unsafe { MmapOptions::new().map(&file)? };
+        let buffer = unsafe { MmapOptions::new().map_copy_read_only(&file)? };
 
         let (n, metadata) = SafeTensors::read_metadata(&buffer).map_err(|e| {
             SafetensorError::new_err(format!("Error while deserializing header: {e:?}"))

diff --git a/flake.nix b/flake.nix
@@ -32,6 +32,7 @@
             postShellHook = ''
               unset SOURCE_DATE_EPOCH
             '';
+            LD_LIBRARY_PATH = "$LD_LIBRARY_PATH:${pkgs.stdenv.cc.cc.lib}/lib";
           };
 
         }

diff --git a/safetensors/Cargo.toml b/safetensors/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "safetensors"
-version = "0.5.0-dev.0"
+version = "0.5.1-dev.0"
 edition = "2021"
 homepage = "https://github.com/huggingface/safetensors"
 repository = "https://github.com/huggingface/safetensors"
-Original file line number
+Diff line change
@@ Expand Up / @@ -32,6 +32,7 @@ @@
                 postShellHook = ''
                   unset SOURCE_DATE_EPOCH
                 '';
+                LD_LIBRARY_PATH = "$LD_LIBRARY_PATH:${pkgs.stdenv.cc.cc.lib}/lib";
               };
             }
@@ Expand Down @@