Fix ORT Trainer #2123
Open
Fix ORT Trainer #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
echarlaix
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Thanks @IlyasMoutawwakil ! Not sure if we should deprecate the ORTTrainer at some point as usage seems low, also cc @JingyaHuang to have her opinion on this
| @@ -818,7 +821,7 @@ def get_dataloader_sampler(dataloader): | |||
| self.control.should_training_stop = True | |||
|
|
|||
| self.control = self.callback_handler.on_epoch_end(args, self.state, self.control) | |||
| self._maybe_log_save_evaluate(tr_loss, grad_norm, model, trial, epoch, ignore_keys_for_eval) | |||
| self._maybe_log_save_evaluate(tr_loss, grad_norm, model, trial, epoch, ignore_keys_for_eval, start_time) | |||
There was a problem hiding this comment.
start_time was introduced in transformers v4.47 https://github.com/huggingface/transformers/blob/v4.47.0/src/transformers/trainer.py#L3021 so maybe we should add a check for the transformers version (min / max supported version) + tests to make sure we keep compatibility with the min/max versions, wdyt @IlyasMoutawwakil ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Who can review?