Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the revision to SentenceTransformer models #2105

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Pass the revision to SentenceTransformer models #2105

merged 1 commit into from
Nov 28, 2024

Conversation

bndos
Copy link
Contributor

@bndos bndos commented Nov 27, 2024

What does this PR do?

Ensures that the revision parameter is passed to SentenceTransformer models in get_model_from_task.

@bndos bndos marked this pull request as draft November 27, 2024 22:16
@bndos bndos marked this pull request as ready for review November 27, 2024 22:17
echarlaix
echarlaix approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @bndos !

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@echarlaix echarlaix merged commit 28bd0ad into huggingface:main Nov 28, 2024
33 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarlaix echarlaix echarlaix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bndos @HuggingFaceDocBuilderDev @echarlaix