Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for siglip models #1563

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add support for siglip models #1563

wants to merge 5 commits into from

Conversation

xenova
Copy link
Contributor

@xenova xenova commented Dec 4, 2023

What does this PR do?

This PR adds support for exporting SigLIP models to ONNX. WIP for this issue.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@xenova
Copy link
Contributor Author

xenova commented Dec 24, 2023

Got it working 🥳 huggingface/transformers.js#473

@xenova xenova marked this pull request as ready for review January 11, 2024 16:22
@xenova
Copy link
Contributor Author

xenova commented Jan 11, 2024

huggingface/transformers#26522 Is now merged into transformers!

@fxmarty
Copy link
Contributor

fxmarty commented Jan 26, 2024

@xenova can you push to this branch so that the CI is rerun?

@xenova
Copy link
Contributor Author

xenova commented Jan 26, 2024

Done ✅ (merged main)

@fxmarty
Copy link
Contributor

fxmarty commented Jan 26, 2024

Thanks! Not sure why we have

=========================== short test summary info ============================
FAILED exporters/onnx/test_onnx_export.py::OnnxExportTestCase::test_all_models_tested - AssertionError: Not testing all models. Missing models: {'siglip-text-with-projection', 'siglip-text-model'}

@Benjoyo
Copy link

Benjoyo commented Apr 28, 2024

Hey @xenova, any status on this? Can we get it merged? :)

I feel that this model is highly relevant and needs optimized inference :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants