Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix generation input for decoder #1515

Closed
wants to merge 1 commit into from
Closed

fix generation input for decoder #1515

wants to merge 1 commit into from

Conversation

echarlaix
Copy link
Collaborator

No description provided.

@echarlaix echarlaix requested a review from fxmarty November 3, 2023 18:38
fxmarty
fxmarty approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - why did we change to the more verbose version? Is it used in transformers?

@echarlaix echarlaix closed this Nov 6, 2023
@echarlaix echarlaix deleted the fix-pkv- branch November 14, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxmarty fxmarty fxmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echarlaix @fxmarty