Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove attn mask patching #1509

Merged
merged 10 commits into from
Nov 2, 2023
Merged

Remove attn mask patching #1509

merged 10 commits into from
Nov 2, 2023

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Nov 2, 2023

Supersede #1473, for some reason I can't push there :/

@fxmarty fxmarty requested a review from echarlaix November 2, 2023 11:32
echarlaix
echarlaix approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @fxmarty

optimum/utils/modeling_utils.py Show resolved Hide resolved
optimum/exporters/onnx/model_patcher.py Show resolved Hide resolved
optimum/exporters/onnx/model_patcher.py Outdated Show resolved Hide resolved
@fxmarty fxmarty merged commit ca19481 into huggingface:main Nov 2, 2023
45 of 52 checks passed
@fxmarty fxmarty mentioned this pull request Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarlaix echarlaix echarlaix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fxmarty @echarlaix @baskrahmer