Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whisper export #1503

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fix whisper export #1503

merged 2 commits into from
Nov 2, 2023

Conversation

mht-sharma
Copy link
Contributor

What does this PR do?

Fixes whisper export for https://huggingface.co/sanchit-gandhi/medium-24-2-tpu-timestamped-prob-0.2/

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@mht-sharma mht-sharma requested review from fxmarty and xenova November 1, 2023 12:45
Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget make style!

(and maybe we can use the whisper-distil in the CI instead of whisper-tiny, if the former is smaller)

Copy link
Contributor

@xenova xenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it worked! I also just tested openai/whisper-tiny.en, and that worked too ;)

(and maybe we can use the whisper-distil in the CI instead of whisper-tiny, if the former is smaller)

whisper-tiny is still smaller :)

@mht-sharma
Copy link
Contributor Author

Done make style: Error was in gptq quantizer from previous commits.

@fxmarty fxmarty merged commit 1aee8ff into huggingface:main Nov 2, 2023
49 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants