Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow tests #95

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Fix slow tests #95

merged 3 commits into from
Sep 24, 2024

Conversation

tengomucho
Copy link
Collaborator

@tengomucho tengomucho commented Sep 24, 2024

What does this PR do?

Slow tests have been failing for a while, this should fix them:

  • For Mistral, a required file for the tokenizer was not downloaded anymore, this should be fixed.
  • Jetstream slow tests were not even run, and installation will now be done with the new make jetstream_requirements command.

Mistral required some vocab file that was not downloaded anymore, maing
the slow tests fail.
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@tengomucho tengomucho marked this pull request as ready for review September 24, 2024 09:44
Add the top_k filtering to increase variability when doing tests with
do_sample.
@tengomucho
Copy link
Collaborator Author

This shows that the branch actually fixes slow tests: https://github.com/huggingface/optimum-tpu/actions/runs/11014471394/job/30585174042

@tengomucho tengomucho merged commit 01d3a42 into main Sep 24, 2024
6 checks passed
@tengomucho tengomucho deleted the fix-slow-tests branch September 24, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants