Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rule and instructions for TGI #18

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Fix rule and instructions for TGI #18

merged 4 commits into from
Apr 8, 2024

Conversation

mfuntowicz
Copy link
Member

No description provided.

Copy link
Collaborator

@tengomucho tengomucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider also changing the docker image name on README.md

Text-Generation-Inference (TGI) is a highly optimized serving engine enabling serving Large Language Models (LLMs) in a way
that better leverages the underlying hardware, Cloud TPU in this case.

TGI comes as ready to use Docker containers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add full stop at the end of the line. Also, should we mention the name?

-e HF_TOKEN=${HF_TOKEN} \
-e HF_BATCH_SIZE=1 \
-e HF_SEQUENCE_LENGTH=1024 \
huggingface/tpu-tgi \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this name correct?

--max-batch-total-tokens 1024
```

### Executing requests against
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you forgot this sentence

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@mfuntowicz mfuntowicz merged commit f4d3aaf into main Apr 8, 2024
1 check passed
@mfuntowicz mfuntowicz deleted the fix-make-tgi-tag branch April 8, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants