Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support num_key_value_heads #447

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

jiqing-feng
Copy link
Collaborator

Hi @echarlaix .

This PR enables models with num_key_value_heads like mistral to generate the correct shape of past_key_values. Could you please help review it after 1440 merged? Thx!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 9, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition @jiqing-feng, can you take a look at the failing tests ?

@jiqing-feng
Copy link
Collaborator Author

jiqing-feng commented Oct 9, 2023

Thanks for the addition @jiqing-feng, can you take a look at the failing tests ?

Yes. I have checked the failed tests. The ipex testing indicates that I didn't install intel_extension_for_pytorch, and the INC testing indicates that "the maximum number of trials specified has been reached and no quantized model meeting the specified accuracy tolerance has been found.".

I think these are not related to my changes

@echarlaix
Copy link
Collaborator

Yes. I have checked the failed tests. The ipex testing indicates that I didn't install intel_extension_for_pytorch, and the INC testing indicates that "the maximum number of trials specified has been reached and no quantized model meeting the specified accuracy tolerance has been found.".

I think these are not related to my changes

Ok I'll take care of fixing it myself then

@echarlaix echarlaix merged commit b5d01f1 into huggingface:main Oct 13, 2023
6 of 10 checks passed
@jiqing-feng jiqing-feng deleted the mistral branch October 16, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants