Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resuming checkpoint without lr schedule or optimizer state #253

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

eliebak
Copy link
Contributor

@eliebak eliebak commented Nov 28, 2024

quick pr to add the possibility to resume training without the optimizer state or lr schedule for continual learning

Copy link
Member

@NouamaneTazi NouamaneTazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! left a qst

@@ -215,7 +215,7 @@ def __init__(
)

# Define iteration start state
if self.init_checkpoint_path is not None:
if self.init_checkpoint_path is not None and self.config.checkpoints.load_lr_scheduler:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this only lr related?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when you want to do a new lr schedule, you also want to do a different data stages + reset the "last_train_step" argument

Copy link
Member

@NouamaneTazi NouamaneTazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NouamaneTazi NouamaneTazi merged commit fdd5151 into huggingface:main Dec 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants