Test inference endpoint model config parsing from path #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
clefourrier
approved these changes
Dec 11, 2024
| base_params: | ||
| # Pass either model_name, or endpoint_name and true reuse_existing | ||
| endpoint_name: "llama-2-7B-lighteval" # needs to be lower case without special characters | ||
| reuse_existing: true # defaults to false; if true, ignore all params in instance, and don't delete the endpoint after evaluation |
Comment on lines
+118
to
+119
| config["base_params"]["model_dtype"] = config["base_params"].pop("dtype", None) | ||
| return cls(**config["base_params"], **config.get("instance", {})) |
There was a problem hiding this comment.
Nice and much cleaner! We might have to add this to all model types
|
@clefourrier I am not sure if you agree in the renaming of the We could address that in a subsequent PR |
This was referenced Dec 12, 2024
NathanHB
pushed a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test inference endpoint model config parsing from path.
As a follow-up of this PR:
this PR implements a test of the parsing of the config file for evaluation in inference endpoints.
To do so, the parsing is factorized into a new method:
Additionally, a new
examples/model_configs/endpoint_model_reuse_existing.yamlis added.Findings:
examples/model_configs/endpoint_model.yaml, the fieldgeneration.add_special_tokenis ignoreddtypein the config file is named asmodel_dtypeInferenceEndpointModelattributeQuestion: should we rename it?
dtypefield in the config file withmodel_dtypemodel_nameinstancefields calledinstance_typeandinstance_size