Misc comments

[LysandreJik]

Only gave a quick look for now, but it's an impressive codebase! It's already very clean, I didn't see anything that jumped to me as being out of the ordinary.

In no specific order, comments about the codebase:

• I would add a stronger message that it originated from the EAIH
• Cool to see initial brrr support!
• Overall well documented and navigation is easy
• Are you expecting to see it be used in conjunction with the doc-builder? It definitely seems like it could be supported
• Very object-oriented/class based which is great.
• You have some env var management in the middle of class definitions (namely os.environ["TOKENIZERS_PARALLELISM"] = "false"). I would either move this in one of the higher-level modules or just put it in the main script
• Some docstrings are yet to be filled out (like the loglikelihood)

[NathanHB]

Thanks Lysandre !

I would add a stronger message that it originated from the EAIH

Do you mean in the README or the code (when using a function that comes from there for example) ?

Are you expecting to see it be used in conjunction with the doc-builder? It definitely seems like it could be supported

Yes, I'm adding some more docstring in another PR then we will use a doc builder.

Thanks for the input on all of these, we will take them into account and try to have fixes this week :)

[clefourrier]

We need to do both, but especially be super strict on code attribution imo - it was a super cool inspiration on a number of classes.

[clefourrier]

Going to close this PR, thanks again a lot @LysandreJik for your feedback!
The 2 last things remaining are the env var and doc, I've created issues so we don't lose track of them.