Pr sadra #393
Merged
Pr sadra #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanHB
reviewed
Nov 18, 2024
clefourrier
commented
Nov 18, 2024
NathanHB
approved these changes
Nov 19, 2024
Sorry I was busy a few days. Looks great. Just a unit test and a docstring typo in |
|
Thanks a lot, yes please do :) |
JoelNiklaus
pushed a commit
to JoelNiklaus/lighteval
that referenced
this pull request
Nov 25, 2024
--------- Co-authored-by: Sadra Barikbin <[email protected]> Co-authored-by: Nathan Habib <[email protected]>
JoelNiklaus
pushed a commit
to JoelNiklaus/lighteval
that referenced
this pull request
Nov 26, 2024
--------- Co-authored-by: Sadra Barikbin <[email protected]> Co-authored-by: Nathan Habib <[email protected]>
hynky1999
pushed a commit
that referenced
this pull request
Nov 29, 2024
--------- Co-authored-by: Sadra Barikbin <[email protected]> Co-authored-by: Nathan Habib <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting #241 so that it fits what we need in lighteval.
@sadra-barikbin can you tell me if anything's missing?