Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OZ Eval task #225

Merged
merged 18 commits into from
Oct 16, 2024
Merged

Adding OZ Eval task #225

merged 18 commits into from
Oct 16, 2024

Conversation

Stopwolf
Copy link
Contributor

Add OZ Eval task for evaluating General Knowledge of LLMs in Serbian. More can be seen DjMel/oz-eval.

Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
Thanks for adding your evaluation.
A number of issues must be addressed - this PR opens up our code to a number of possible vulnerabilities, please change it.

@NathanHB
Copy link
Member

Hi ! Thanks for your contribution. I tested the task locally and you need to change the null to None. Also you will need to format your code with make style for the tests to pass.

@Stopwolf Stopwolf requested a review from clefourrier August 27, 2024 09:36
@NathanHB
Copy link
Member

@clefourrier You need to accept the changes so that we can merge the PR :)

@clefourrier
Copy link
Member

Tests are not passing though?

@Stopwolf
Copy link
Contributor Author

Tests arent passing because of Invalid username or password in the following test:

tests/logging/test_evaluation_tracker.py:147: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
src/lighteval/logging/evaluation_tracker.py:185: in save
    self.push_to_hub(
src/lighteval/logging/evaluation_tracker.py:252: in push_to_hub
    self.api.create_repo(repo_id, private=not (self.public), repo_type="dataset", exist_ok=True)

Any idea how to fix this, or if it's even something on my side? Thanks @NathanHB 🤗

@clefourrier
Copy link
Member

Hi! We normally added a fix for this (sorry for the late answer), re-running the tests again

@clefourrier clefourrier merged commit e27aa0e into huggingface:main Oct 16, 2024
2 checks passed
@clefourrier
Copy link
Member

Thanks for the eval!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants