-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few typos and do a tiny refactor #187
Conversation
evaluation_tracker.py
and model_config.py
Also there's no argument called lighteval/src/lighteval/models/model_config.py Lines 274 to 275 in 51c06d6
|
hey thanks for the PR ! the model config arg was deprecated in favor of a file. we forgot to remove the in the constructor. |
evaluation_tracker.py
and model_config.py
I'm done @NathanHB |
hey ! thanks for the PR, lgtm, i will test it locally next week and merge asap :) |
Hi @sadra-barikbin , just took a look at your PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Hi there!
To fix a few typos and do a tiny refactor.