-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
launch lighteval using lighteval --args
#152
Conversation
This reverts commit 40df0c2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, super useful
@@ -94,7 +94,8 @@ accelerate config | |||
You can then evaluate a model using data parallelism as follows: | |||
|
|||
```shell | |||
accelerate launch --multi_gpu --num_processes=<num_gpus> run_evals_accelerate.py \ | |||
accelerate launch --multi_gpu --num_processes=<num_gpus> -m \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fond of accelerate ... lighteval accelerate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree but not sure how we could really differenciate between nanotron and accelerate launchers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, can you launch nanotron with accelerate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdym ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we'll ever get accelerate launch ... lighteval nanotron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we could assume that if accelerate launch
is used, then it's lighteval accelerate?
lighteval.commands.parsers
Registry
classhow to use:
with nanotron
nothing changes except for the use of the cli executable
with accelerate
accelerate args now need to be passed to the lighteval script.