Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #10 from huggingface/fix-target-perplexity" #14

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

NathanHB
Copy link
Member

@NathanHB NathanHB commented Feb 5, 2024

This reverts commit 1925742, reversing changes made to 0cf83ce.

Wanted to simply reset and git push --force but this is cleaner.

clefourrier
clefourrier previously approved these changes Feb 5, 2024
Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but that means we lose the initial fix included in d0e9be9 to 50c18f9. You could also revert only the last 3 commits on main.

@clefourrier clefourrier merged commit c50e19f into main Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants