Update model_license_other.md #993
Conversation
Hi guys! I opened my first PRs for huggingface#985 - Just want to be sure I did that 1 right, I will be updating the model card license for a lot more models now that I have broken the ice.
| @@ -73,7 +73,7 @@ Here is the list of models with `license:other` and a LICENSE file in the repo. | |||
|
|
|||
| |status|pr_url |model_id|nb_downloads|nb_likes |suggested_license_name |suggested_license_link |license_url |license_url_2 |license_url_3 | | |||
| |------|----------------------------------------------------------------------------|--------|------------|-------------------------|----------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------| | |||
| | | |[decapoda-research/llama-7b-hf](https://huggingface.co/decapoda-research/llama-7b-hf)|379224 |1223 |llama-license |https://huggingface.co/decapoda-research/llama-7b-hf/blob/main/LICENSE |[LICENSE](https://huggingface.co/decapoda-research/llama-7b-hf/blob/main/LICENSE) | | | | |||
| |Opened|https://huggingface.co/decapoda-research/llama-7b-hf/discussions/125|[decapoda-research/llama-7b-hf](https://huggingface.co/decapoda-research/llama-7b-hf)|379224 |1223 |llama-license |https://huggingface.co/decapoda-research/llama-7b-hf/blob/main/LICENSE |[LICENSE](https://huggingface.co/decapoda-research/llama-7b-hf/blob/main/LICENSE) | | | | |||
There was a problem hiding this comment.
Yes, this is the idea @thanktua-spp! Thanks for opening the PR 🎉
2 remarks though:
- It's better to wrap the PR url like this
[here](https://huggingface.co/decapoda-research/llama-7b-hf/discussions/125). This doesn't change much but will make the table more readable on GitHub. - The model you reported is not under Llama2 license, but under the 1st Llama version. In that case it's best to keep
license:other, addlicense_name:llamaand finally link to the LICENSE in the repo aslicense_link: https://huggingface.co/decapoda-research/llama-7b-hf/blob/main/LICENSE
Does that work for you? :)
There was a problem hiding this comment.
thanks so much, @Wauplin this was very helpful feedback. Many thanks.
|
Thanks for making the change @thanktua-spp! Looks good to me like this. I've resolved the merge conflict and will now merge this PR. Well done! |
|
thanks so much for supporting @Wauplin, I will go ahead and make some more updates. BTW are there any other Hectoberfest challenges to look forward to? I am already feeling confident 🤗 |
|
And... merged!
Yes! So for now we have three challenges related to metadata on the Hub (see #985, #986 and #995). And we are thinking about releasing new ones during the Hacktoberfest! |
|
thanks so much for sharing @Wauplin. |
Hi guys!
I opened my first PRs for #985 - Just want to be sure I did that 1 right, I will be updating the model card license for a lot more models now that I have broken the ice.