-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hacktoberfest: new languages pt.2 #992
Hacktoberfest: new languages pt.2 #992
Conversation
I will resolve merge conflicts soon 🤗 |
Resolved :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for these!! To ensure we have the most impact with these PRs going forward, we'll focus first on datasets with more downloads (at least 10).
I'll update the guidance shortly, but basically we'll use a threshold of>10 downloads for deciding which datasets to target with PRs :)
Hey @davanstrien @stefan-it , I had a doubt, when I made the PR I submitted the status as Opened for my PR URL, and #997 was merged. A few days back #992 was merged which removes the Opened status from the table but keeps only Merged and Closed, my query is in future PRs shall I mention Opened or just stick with Merged and Closed? Because now I cannot find the status 😅 |
Hey @snehilsanyal , I think I removed the opened status. My main intention was that the overview table is then more clear, because then you only have to look for rows that have no information in first column 🤗 |
@snehilsanyal, sorry missed that change in the PR! It's okay to keep with this new format now. I'll make sure to update the instructions soon. |
Thank you for your reply @stefan-it 🤗 |
I've had another look at this, and I think it's okay with the new format. It's possible to see if a PR has been opened (even if it's not merged), so I think this should make it clear enough that it has been worked on. I'll add some clarifying instructions though :) |
Thanks @davanstrien 🤗 and sorry for reiterating 😅 😄 |
Hi,
I created some PRs that add language tag(s) to datasets for the Hacktoberfest 🤗
Additionally, the status merged status information was updated.
Checkups
In order to ensure no duplicate entries, here's some check:
Should never return any values > 1 :)