Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacktoberfest: new languages pt.2 #992

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

stefan-it
Copy link
Contributor

@stefan-it stefan-it commented Oct 3, 2023

Hi,

I created some PRs that add language tag(s) to datasets for the Hacktoberfest 🤗

Additionally, the status merged status information was updated.

Checkups

In order to ensure no duplicate entries, here's some check:

$ cat hacktoberfest_challenges/datasets_without_language.md | grep "|" | cut -d "|" -f 4 | sort | uniq -c | sort -n
$ cat hacktoberfest_challenges/datasets_without_language.csv | sort | uniq -c | sort -n

Should never return any values > 1 :)

@stefan-it
Copy link
Contributor Author

I will resolve merge conflicts soon 🤗

@stefan-it
Copy link
Contributor Author

Resolved :)

Copy link
Member

@davanstrien davanstrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for these!! To ensure we have the most impact with these PRs going forward, we'll focus first on datasets with more downloads (at least 10).

I'll update the guidance shortly, but basically we'll use a threshold of>10 downloads for deciding which datasets to target with PRs :)

@davanstrien davanstrien merged commit 6d3f567 into huggingface:main Oct 5, 2023
@snehilsanyal
Copy link
Contributor

snehilsanyal commented Oct 9, 2023

Hey @davanstrien @stefan-it , I had a doubt, when I made the PR I submitted the status as Opened for my PR URL, and #997 was merged. A few days back #992 was merged which removes the Opened status from the table but keeps only Merged and Closed, my query is in future PRs shall I mention Opened or just stick with Merged and Closed? Because now I cannot find the status 😅
image

@stefan-it
Copy link
Contributor Author

Hey @snehilsanyal , I think I removed the opened status. My main intention was that the overview table is then more clear, because then you only have to look for rows that have no information in first column 🤗

@stefan-it stefan-it deleted the hacktoberfest-languages-pt2 branch October 9, 2023 11:24
@davanstrien
Copy link
Member

@snehilsanyal, sorry missed that change in the PR! It's okay to keep with this new format now. I'll make sure to update the instructions soon.

@snehilsanyal
Copy link
Contributor

Thank you for your reply @stefan-it 🤗
I get your point, but I also think if the Opened status is not there, there are chances any other newcomers will stumble upon datasets that already have PR opened, so they will go to the link and realize the PR is already open.
Thank you @davanstrien, will stick to the format for now, and will wait for further instructions on this 🤗

@davanstrien
Copy link
Member

I've had another look at this, and I think it's okay with the new format. It's possible to see if a PR has been opened (even if it's not merged), so I think this should make it clear enough that it has been worked on. I'll add some clarifying instructions though :)

@snehilsanyal
Copy link
Contributor

Thanks @davanstrien 🤗 and sorry for reiterating 😅 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants