Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hacktoberfest] Model license:other + Dataset languages challenges #981

Merged
merged 14 commits into from
Oct 2, 2023
Merged

[hacktoberfest] Model license:other + Dataset languages challenges #981

merged 14 commits into from
Oct 2, 2023

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Sep 29, 2023 •
edited
Loading

First discussed on slack (private link).

Adding some instructions + a table. Let's iterate from this :)

See:

@Wauplin Wauplin changed the title [hacktoberfest] License:other challenge [hacktoberfest] Model license:other challenge Sep 29, 2023
@davanstrien
Copy link
Member

I made a few quick suggestions for style. Will take another look on Monday morning :)

osanseviero
osanseviero approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

hacktoberfest_challenges/model_license_other.md Show resolved Hide resolved
hacktoberfest_challenges/model_license_other.md Outdated Show resolved Hide resolved
hacktoberfest_challenges/model_license_other.md Outdated Show resolved Hide resolved
hacktoberfest_challenges/model_license_other.md Outdated Show resolved Hide resolved
hacktoberfest_challenges/model_license_other.md Outdated Show resolved Hide resolved
osanseviero
osanseviero approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also worth mentioning how to add an existing license. E.g. for many repos we can potentially switch to the llama2 license rather than other. Showing how to do that would be good as well

@davanstrien
Copy link
Member

I have uploaded task data/description for the dataset language ID task.

@Wauplin
Copy link
Contributor Author

Wauplin commented Oct 2, 2023

Thanks for the review @osanseviero. I updated the file to add special instructions for Llama 2 models (see 0c0edba). Could you give it a quick look?

@Wauplin
Copy link
Contributor Author

Wauplin commented Oct 2, 2023

I have uploaded task data/description for the dataset language ID task.

Oh indeed, that's why git didn't want me to push 😄 I think we did it at the same time. I'll have a look!

Wauplin
Wauplin commented Oct 2, 2023
View reviewed changes
Copy link
Contributor Author

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Datasets languages" challenge looks good to me. I would add a question in FAQ about multi-language datasets (as I was myself wondering about it when reading 😄). Otherwise I think we're good to merge.

hacktoberfest_challenges/datasets_without_language.md Outdated Show resolved Hide resolved
hacktoberfest_challenges/datasets_without_language.md Show resolved Hide resolved
@davanstrien
Copy link
Member

"Datasets languages" challenge looks good to me. I would add a question in FAQ about multi-language datasets (as I was myself wondering about it when reading 😄). Otherwise I think we're good to merge.

Good idea, just added a clarification for this.

@Wauplin Wauplin changed the title [hacktoberfest] Model license:other challenge [hacktoberfest] Model license:other + Dataset languages challenges Oct 2, 2023
@Wauplin Wauplin merged commit f2b43c7 into main Oct 2, 2023
@Wauplin Wauplin deleted the hacktoberfest-challenges-license-other branch October 2, 2023 09:25
@Wauplin
Copy link
Contributor Author

Wauplin commented Oct 2, 2023

Merged!

@Wauplin Wauplin mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osanseviero osanseviero osanseviero approved these changes

@julien-c julien-c Awaiting requested review from julien-c

@davanstrien davanstrien Awaiting requested review from davanstrien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wauplin @davanstrien @osanseviero