Proposal: widget types #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
reviewed
Sep 29, 2023
julien-c
reviewed
Sep 29, 2023
julien-c
reviewed
Sep 29, 2023
js/src/lib/components/InferenceWidget/shared/WidgetInputSamples/WidgetInputSamples.svelte
Outdated
Show resolved
Hide resolved
…s/WidgetInputSamples.svelte Co-authored-by: Julien Chaumond <[email protected]>
julien-c
approved these changes
Sep 29, 2023
julien-c
reviewed
Sep 29, 2023
...omponents/InferenceWidget/widgets/AudioClassificationWidget/AudioClassificationWidget.svelte
Outdated
Show resolved
Hide resolved
mishig25
reviewed
Sep 29, 2023
| import type { WidgetExample } from "../WidgetExample"; | ||
| type T = $$Generic<WidgetExample>; |
There was a problem hiding this comment.
like TOutput, maybe a more descriptive name like TWidgetInput or TWidgetExample would make it clear. If so, should apply to other files as well
There was a problem hiding this comment.
you prefer this syntax to the generics="T extends WidgetExample"> syntax BTW @SBrandeis?
(i think both are equivalent no?)
SBrandeis
commented
Sep 29, 2023
Comment on lines
+38
to
40
| export interface WidgetExampleTextAndTableInput<TOutput = WidgetExampleOutput> extends WidgetExampleTextInput<TOutput> { | ||
| table: (string | number)[][]; | ||
| } |
There was a problem hiding this comment.
I think this one is not compatible with the server-side validation of https://github.com/huggingface/moon-landing/pull/7601 @julien-c
There was a problem hiding this comment.
arf yes, correct. will fix the moon-landing PR
julien-c
reviewed
Sep 29, 2023
| function _isZeroShotTextInput<TOutput>( | ||
| sample: WidgetExample<TOutput> | ||
| ): sample is Exclude<WidgetExampleZeroShotTextInput<TOutput>, "text"> { | ||
| return "candidate_labels" in sample && "multi_class" in sample; |
There was a problem hiding this comment.
you don't check the types because you trust moon-landing validation, is that correct?
julien-c
added a commit
that referenced
this pull request
Sep 29, 2023
* Typings for all kinds of widget examples * Add a //#region block * Tweaks * Fix some part of the CI already(?) cc @krampstudio @mishig25 for review 🙏 * Revert "Fix some part of the CI already(?)" This reverts commit 3e89028. * nvm, probably better like this * sorry this was wrong * 🤯 Use generics in Svelte (i guess...) * Proposal: widget types (#980) * wip * 🩹 Fix types in widgets * 🩹 Minimize diff * 💄 Lint * Update js/src/lib/components/InferenceWidget/shared/WidgetInputSamples/WidgetInputSamples.svelte Co-authored-by: Julien Chaumond <[email protected]> * 🧹 cleanup unwanted change * 🩹 wip: type safety * ✨ Typing & validation for ALL widgets * ♻️ Slightly less verbose version * 🩹 * 🩹 Import type? * 🩹 Alternative generic syntax to satisfy svelte-check --------- Co-authored-by: Julien Chaumond <[email protected]> * 💄 Lint & checks * Go for same syntax everywhere --------- Co-authored-by: Simon Brandeis <[email protected]> Co-authored-by: SBrandeis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wdyt @julien-c @mishig25 ?