[doc+spec] Widget example outputs #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's not ready to merge yet but still would love some preliminary reviews/to hear your thoughts. cc @Wauplin too on this BTW |
|
The documentation is not available anymore as the PR was closed or merged. |
gary149
reviewed
Sep 28, 2023
Wauplin
reviewed
Sep 28, 2023
There was a problem hiding this comment.
Spec (and feature) looks good to me!
You've mentioned 2 (not sure) items about the ability to set a file or text as output (instead of json-encoded output) => I really think it'd be a great improvement. I feel that it can cover a lot of cases of "too big to load" models.
mishig25
reviewed
Sep 28, 2023
julien-c
commented
Sep 29, 2023
Co-authored-by: Lucain <[email protected]>
|
ready for final review!! |
mishig25
reviewed
Sep 29, 2023
mishig25
reviewed
Sep 29, 2023
mishig25
reviewed
Sep 29, 2023
mishig25
reviewed
Sep 29, 2023
mishig25
reviewed
Sep 29, 2023
mishig25
approved these changes
Sep 29, 2023
Co-authored-by: Omar Sanseviero <[email protected]> Co-authored-by: Mishig <[email protected]>
Co-authored-by: Omar Sanseviero <[email protected]> Co-authored-by: Mishig <[email protected]>
|
Merging with 1 approval |
This was referenced Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important commit to take a look at, is 8ec6abc
Basically this specs out:
outputfor each example in thewidget:section.See 8ec6abc