Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger CI #966

Merged
merged 3 commits into from
Sep 25, 2023
Merged

trigger CI #966

merged 3 commits into from
Sep 25, 2023

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Sep 25, 2023

cc @mishig25 it seems that the recent update broke the formatting of URLs that contains some {}.

See https://github.com/huggingface/hub-docs/actions/runs/6298189570/job/17096558681?pr=962 (from PR #962). I created this PR to trigger the CI on the current main branch.

EDIT: we were adding invalid URLs anyway. Let's just remove the interpolation marks in the urls and that's it (urls when clicking on the demo "sign in with HF" buttons).

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 25, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks a lot for fixing it

@Wauplin Wauplin merged commit 45e4211 into main Sep 25, 2023
1 check passed
@Wauplin Wauplin deleted the ci-doc-test-interpolation-in-url branch September 25, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants