-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generate script after new snippets #1490
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
(unrelated) there seems to be an issue with "conversational" image-text-to-text snippet where |
For non-conversational image-text-to-text, we're using the conversational image-text-to-text snippet, this is why we have this weird combination. I will merge this PR but we should fix this by adding image-text-to-text task inputs here to have a proper requests-based snippet when the VLM is not conversational. Note: all warm models in the Inference API are currently conversational VLMs. |
I think this was an issue in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Left a nit but otherwise looks good to merge :)
(I cannot approve my own PR even though the code is not mine anymore ^^)
@@ -9,8 +9,8 @@ importers: | |||
.: | |||
dependencies: | |||
'@huggingface/tasks': | |||
specifier: ^0.11.11 | |||
version: 0.11.11 | |||
specifier: ^0.12.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest is 0.13.2
(https://www.npmjs.com/package/@huggingface/tasks) and should fix the import issue. (can be done in a later PR, typically the automated one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed! i will add that in #1480
Happy to close if duplicate work