Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] Enterprise docs #1089

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[Hotfix] Enterprise docs #1089

merged 1 commit into from
Nov 7, 2023

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Nov 7, 2023 •
edited
Loading

At the moment, doc-builder uses markdown headings for creating right-side nav (see attached img for example)

image

I will work on supporting html headings for right-side nav. Until then, this is a hotfix

@mishig25 mishig25 requested a review from julien-c November 7, 2023 17:32
julien-c
julien-c approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's super weird is that it worked in CI, at least when partial-loading (didn't work when doing a full page load)

@mishig25 mishig25 merged commit 9f24d58 into main Nov 7, 2023
1 check passed
@mishig25 mishig25 deleted the hotfix_enterprise_docs branch November 7, 2023 17:33
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-c julien-c julien-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mishig25 @HuggingFaceDocBuilderDev @julien-c