change metadata key from finetuned_from to base_model
#1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Fine with me, although what if the model is fine-tuned from a model that's
been fine-tuned (is not the base model)?
Agree that `base_model` should be a metadata tag, though.
…On Mon, Nov 6, 2023, 11:03 AM Julien Chaumond ***@***.***> wrote:
@julien-c <https://github.com/julien-c> requested your review on: #1084
<#1084> change metadata key
from finetuned_from to base_model.
—
Reply to this email directly, view it on GitHub
<#1084 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVSIJ6ZOMRBJ2HN2IM5KVZTYDC7Y3AVCNFSM6AAAAAA67KBM22VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHA3TCMRQGEYTGMQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
@meg-huggingface good point, in our spec base_model is the direct "parent" so the keyword is a bit confusing vs. the transitive "topmost" base model The good news is that we can compute the "topmost" grand-grand-[...]-parent quite easily from the HF API |
osanseviero
approved these changes
Nov 6, 2023
|
thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see internal discussion there https://huggingface.slack.com/archives/C01BWJU0YKW/p1687766681122359
related to (internal) https://github.com/huggingface/moon-landing/pull/7989