Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for Enterprise Hub #1081

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Docs for Enterprise Hub #1081

merged 6 commits into from
Nov 7, 2023

Conversation

julien-c
Copy link
Member

@julien-c julien-c commented Nov 3, 2023 •
edited
Loading

TL;DR: adding an entry point re. all Enterprise Hub features

see the doc-build here: https://moon-ci-docs.huggingface.co/docs/hub/pr_1081/ (as soon as it will be built)

So we can point prospective customers to those docs

a few Screenshots (but open the doc-build instead)

image

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 3, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@julien-c
Copy link
Member Author

julien-c commented Nov 3, 2023

@mishig25 docs for this PR does not seem to work for some reason 🙏

@mishig25
Copy link
Collaborator

mishig25 commented Nov 3, 2023

looking into it. Somehow, the docs are rendering the main branch rather than the PR branch

@mishig25
Copy link
Collaborator

mishig25 commented Nov 3, 2023

It is working https://moon-ci-docs.huggingface.co/docs/hub/pr_1081/en/billing no ?

image

@julien-c
Copy link
Member Author

julien-c commented Nov 3, 2023 •
edited
Loading

ah yes seems to work now 👍 (i had a 404)

@julien-c
Copy link
Member Author

julien-c commented Nov 3, 2023 •
edited
Loading

arg it failed now for some reason @mishig25 nvm issue on my side

@mishig25
Copy link
Collaborator

mishig25 commented Nov 3, 2023 •
edited
Loading

You got 404 probably while the docbuild artifacts were being uploaded to moonci docs server

@Pierrci
Copy link
Member

Pierrci commented Nov 3, 2023

The Enterprise icon looks a bit weird/lonely to me, no? Did you mean to put it inline with the title?

image

Other than that, LGTM

@abidlabs
Copy link
Member

abidlabs commented Nov 3, 2023

Agree with @Pierrci, also the same issue is on the main Enterprise Hub page:

image

@abidlabs
Copy link
Member

abidlabs commented Nov 3, 2023

This screenshot is a bit too large:

image

Otherwise, screenshots are quite nice! LGTM

jeffboudier
jeffboudier approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@jeffboudier jeffboudier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for adding this!

docs/hub/enterprise-hub.md Outdated Show resolved Hide resolved
docs/hub/enterprise-hub.md Show resolved Hide resolved
docs/hub/billing.md Outdated Show resolved Hide resolved
docs/hub/billing.md Outdated Show resolved Hide resolved
docs/hub/billing.md Outdated Show resolved Hide resolved
docs/hub/storage-regions.md Outdated Show resolved Hide resolved
docs/hub/storage-regions.md Outdated Show resolved Hide resolved
docs/hub/storage-regions.md Outdated Show resolved Hide resolved
docs/hub/audit-logs.md Show resolved Hide resolved
docs/hub/audit-logs.md Outdated Show resolved Hide resolved
LysandreJik
LysandreJik approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@julien-c
Copy link
Member Author

julien-c commented Nov 6, 2023

@Pierrci @abidlabs yep i wanted to inline the icon but there's no easy way in markdown to inline an image, correct?

i'll need to write a bit of HTML i guess

@julien-c julien-c requested a review from osanseviero November 6, 2023 19:11
@julien-c
Copy link
Member Author

julien-c commented Nov 7, 2023 •
edited
Loading

i'll merge this today or tomorrow, time for any final reviews!

@julien-c
Copy link
Member Author

julien-c commented Nov 7, 2023

@abidlabs ceb0d9e

@julien-c
Copy link
Member Author

julien-c commented Nov 7, 2023

ok looks quite good now with a small inline icon for Enterprise, so let's merge
image

@julien-c julien-c merged commit 4699076 into main Nov 7, 2023
1 check passed
@julien-c julien-c deleted the docs-regions branch November 7, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffboudier jeffboudier jeffboudier approved these changes

@LysandreJik LysandreJik LysandreJik approved these changes

@abidlabs abidlabs abidlabs approved these changes

@coyotte508 coyotte508 coyotte508 approved these changes

@gary149 gary149 Awaiting requested review from gary149

@Pierrci Pierrci Awaiting requested review from Pierrci

@Kakulukian Kakulukian Awaiting requested review from Kakulukian

@Michellehbn Michellehbn Awaiting requested review from Michellehbn

@VioletteLepercq VioletteLepercq Awaiting requested review from VioletteLepercq

@SBrandeis SBrandeis Awaiting requested review from SBrandeis

@allendorf allendorf Awaiting requested review from allendorf

@adeenayakup adeenayakup Awaiting requested review from adeenayakup

@osanseviero osanseviero Awaiting requested review from osanseviero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@julien-c @HuggingFaceDocBuilderDev @mishig25 @Pierrci @abidlabs @coyotte508 @LysandreJik @jeffboudier