-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API docs mini tweaks #1075
API docs mini tweaks #1075
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I also pushed a commit to your branch to remove config
from /api/spaces
route (cc @enzostvs). Hope you don't mind :)
@@ -139,11 +138,6 @@ Get all information for a specific model. | |||
|
|||
This is equivalent to `huggingface_hub.space_info(repo_id, revision)`. | |||
|
|||
### GET /api/metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't like https://huggingface.co/api/metrics or just that you don't think it should be listed among the listing APIs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no strong opinion. fine with me to remove it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen it used personally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Let's merge this PR then 👍
very minor tweaks, the main one was that i didn't really like
Search API
(confusing with the Hub full text search)