Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structuredData -> structured_data #1064

Merged
merged 1 commit into from
Oct 30, 2023
Merged

structuredData -> structured_data #1064

merged 1 commit into from
Oct 30, 2023

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Oct 30, 2023

For, the widget example attributes, all names use snake_case (like candidate_labels, multi_class) except structuredData , which is using camelCase. This PR renames structuredData -> structured_data

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 30, 2023

The documentation is not available anymore as the PR was closed or merged.

@julien-c
Copy link
Member

hmm ok but you need to open PRs to change the models on the Hub then (there are not that many of those, so should be doable)

e.g. https://huggingface.co/julien-c/wine-quality/blob/main/README.md?code=true#L9

@mishig25
Copy link
Collaborator Author

you need to open PRs to change the models on the Hub

will do so

@mishig25 mishig25 merged commit d0180ef into main Oct 30, 2023
3 checks passed
@mishig25 mishig25 deleted the widget_example_snake_case branch October 30, 2023 15:07
@julien-c
Copy link
Member

julien-c commented Oct 30, 2023

Note that you also have occurences of structuredData in the moon-landing codebase (in Modelcard.ts for instance).... can you please open a PR there?

@julien-c
Copy link
Member

there are even some remaining occurences inside hub-docs!

@mishig25
Copy link
Collaborator Author

Note that you also have occurences of structuredData in the moon-landing codebase

opened a companion PR

there are even some remaining occurences inside hub-docs!

I might be missing something. I don't see any in this search here.
There is this line (note the typo strucured vs structured PR #1069). In this case, this variable will not cause any problem because it has no relation to the query param strucured_data. So I don't think there is any remaining occurences inside hub-docs. Correct me if I'm wrong

@julien-c
Copy link
Member

There's one in index.svelte

@julien-c
Copy link
Member

oh nvm looks like it was changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants