~~[Widgets] Don't call api inference if output exists~~ #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishig25
requested review from
julien-c,
gary149,
osanseviero,
SBrandeis and
coyotte508
julien-c
reviewed
Oct 13, 2023
|
|
||
| async function getOutput({ withModelLoading = false, isOnLoadCall = false, sampleOutput = undefined }: GetOutputOptions = {}) { | ||
| // don't call api-inference if sample output already exists | ||
| if(isValidOutputLabels(sampleOutput)) { |
...omponents/InferenceWidget/widgets/AudioClassificationWidget/AudioClassificationWidget.svelte
Outdated
Show resolved
Hide resolved
|
Logic sounds good to me too |
mishig25
changed the title
osanseviero
reviewed
Oct 18, 2023
...omponents/InferenceWidget/widgets/AudioClassificationWidget/AudioClassificationWidget.svelte
Outdated
Show resolved
Hide resolved
mishig25
force-pushed
the
don_compute_output_exists
branch
from
6c8db96 to
2cc7ec1
Compare
mishig25
force-pushed
the
don_compute_output_exists
branch
from
2cc7ec1 to
cd15b19
Compare
mishig25
changed the title
Superceded by #1063 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superceded by #1063
Closes #1011
Follow up to #979
#979 correctly implemented behaviour for the previewInputSample function here. Which is: don't call api-inference if
sample.outputexistsThe same should be the case for
applyInputSampleandonMountexample (which is this PR). Don't call api-inference ifsample.outputexists. #1011 happened because api-inference was called and there was no cached example althoughsample.outputwas in the repoWdyt of the proposed solution? I've only implemented for AudioClassificationWidget.svelte. If others agree with the design, will implement for other widgets as well
** for the clarification,
previewInputSamplefunction gets called when you hover over different input samples.applyInputSamplefunction gets called when you end up clicking/selecting inout sampleOrder of merge operations