Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docsUrl attribute to interface LibraryUiElement #1015

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Conversation

@mishig25 mishig25 marked this pull request as ready for review October 11, 2023 12:48
@Vaibhavs10
Copy link
Member

Dope! Happy to help, sure! From the context I've gathered so far this means that we need a page similar to this (ESPNet) right?
https://huggingface.co/docs/hub/espnet

I can add this next week for NeMo and Pyannote-audio.
Idk much about fairseq (have worked more with fairseq2) - but if there's nobody with more experience than me then I'm happy to pick it up too.

@mishig25
Copy link
Collaborator Author

Btw, we can approve/merge this PR without needing all the libs to have docs pages. I just listed them in the description to keep track of them

@pcuenca
Copy link
Member

pcuenca commented Oct 12, 2023

@mishig25 I agree, we can open those in a follow-up PR

@mishig25 mishig25 merged commit 4bc8d98 into main Oct 13, 2023
2 checks passed
@mishig25 mishig25 deleted the lib_docs_url branch October 13, 2023 07:49
@pcuenca pcuenca mentioned this pull request Oct 13, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants