Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scheduler] support custom
timesteps
andsigmas
#7817[scheduler] support custom
timesteps
andsigmas
#7817Changes from 15 commits
8dfe500
b0017f4
967ee64
9a23c53
e51cb15
b6aeeca
9d700f3
012687d
3ddf2fe
7d5e564
bd8e138
eeac9ee
1c72f23
15e39e4
0cb7805
faff7bf
2f896da
80f6920
4c4f7ba
2d54598
56407ae
9cd36ef
80ec506
bc5eff4
e70808e
aa82491
388d5d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would be better to add a method to the scheduler, like
scheduler._accepts_sigmas()
orscheduler._check_sigmas(sigmas)
instead of inspecting. Same argument for corresponding methods below.